Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Updating a look where the shader name changed leaves the geo without a shader #237

Closed
mkolar opened this issue Jun 10, 2020 · 1 comment
Closed
Assignees
Labels
host: Maya sponsored Client endorsed or requested type: bug Something isn't working

Comments

@mkolar
Copy link
Member

mkolar commented Jun 10, 2020

Describe the bug
Updating a look to latest version using scene inventory GUI leaves the geo without a shader, in cases where a name of the shader changed between the version. Even though the renamed shader has all correct id assignments.

To Reproduce
Steps to reproduce the behavior:

  1. Publish a look for a model
  2. Load the look onto a model in a different scene (setdress for example) using look manager
  3. In the lookdev scene, change the name of one of the shaders and publish another version
  4. In the "setdress" scene open scene inventory and update the look to latest version
  5. The object that has the renamed look applied to it, ends up without any shader.

Expected behavior
Look updating should work the same as all other families from the scene inventory. That means that we'll need to duplicate some of the logic from look assigned to the update method of the look loader

@mkolar mkolar added type: bug Something isn't working host: Maya sponsored Client endorsed or requested MEDIUM labels Jun 10, 2020
@kalisp kalisp self-assigned this Sep 4, 2020
@create-issue-branch
Copy link

kalisp added a commit to kalisp/pype that referenced this issue Sep 10, 2020
Added cleanup of references with failed reference edits
kalisp added a commit to kalisp/pype that referenced this issue Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya sponsored Client endorsed or requested type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants