Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Feature/273 pyblish pype toggle instance callback #275

Merged
merged 4 commits into from
Jun 16, 2020
Merged

Feature/273 pyblish pype toggle instance callback #275

merged 4 commits into from
Jun 16, 2020

Conversation

iLLiCiTiT
Copy link
Member

Base branch is #268

Instance toggle trigger callbacks in pyblish.api for instanceToggle signal.

Resolves: #273

@iLLiCiTiT iLLiCiTiT self-assigned this Jun 16, 2020
@tokejepsen
Copy link
Member

Seem to get this error: TypeError: invalid result from InstanceItem.setData().
Did merge in #266 as well.

@mkolar
Copy link
Member

mkolar commented Jun 16, 2020

working for me it seems in Nuke

@tokejepsen
Copy link
Member

Sorry yeah it does work, but seems to be reversed. The callbacks expect:

on_pyblish_instance_toggled(instance, old_value, new_value)

not

on_pyblish_instance_toggled(instance, new_value, old_value)

@mkolar mkolar merged commit 454c197 into release/2.10.0 Jun 16, 2020
@mkolar mkolar added this to the 2.10 milestone Jun 23, 2020
@mkolar mkolar deleted the feature/273-Pyblish-pype_toggle_instance_callback branch July 8, 2020 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

@tokejepsen tokejepsen Awaiting requested review from tokejepsen

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
None yet
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @tokejepsen @mkolar