Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

3.0 lib refactor #664

Closed
mkolar opened this issue Oct 26, 2020 · 4 comments · Fixed by #513, #681 or #669
Closed

3.0 lib refactor #664

mkolar opened this issue Oct 26, 2020 · 4 comments · Fixed by #513, #681 or #669
Assignees
@kalisp
Labels
type: enhancement Enhancements to existing functionality
Milestone
2.14.0

Comments

@mkolar
Copy link
Member

mkolar commented Oct 26, 2020 •
edited
Loading

To move with pype 3.0, we need to refactor lib.py which is a mishmash of functions into a clean testable code inside a new lib python module.

The agreed plan is to split it into individual tasks. Everyone takes functions they wrote originally, judges where it needs to go, refactors, writes tests, if time allows. PRs with individual functions of groups of functions after refactor, should be made into feature/664-3-0-lib-refactor branch. Once everything is pulling into it, we'll merge into develop.

@kalisp will be reviewing smaller PRs to ensure consistency of code style, docstrings and general approach.
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Oct 26, 2020
@mkolar mkolar self-assigned this Oct 26, 2020
@create-issue-branch
Copy link

Branch feature/664-3-0-lib-refactor created!

@mkolar mkolar assigned kalisp and unassigned mkolar Oct 26, 2020
@mkolar mkolar added this to the 2.14 milestone Oct 26, 2020
@jakubjezek001
Copy link
Member

jakubjezek001 commented Oct 28, 2020 •
edited
Loading

Just to clarify this: are we suppose to branch from feature/664-3-0-lib-refactor and then after create PR with target to feature/664-3-0-lib-refactor back?

update: confirmed over chat that that is the workflow to follow

@kalisp
Copy link
Member

kalisp commented Oct 28, 2020

Yes, I would think so.

@kalisp kalisp self-assigned this Oct 28, 2020
@kalisp
Copy link
Member

kalisp commented Nov 2, 2020

Link to list of references https://docs.google.com/spreadsheets/d/17w3czPixTYYyeXoSAxlGTtoBQMbffpUAyTysiehE0MU/edit?usp=sharing

This was linked to pull requests Nov 3, 2020
Pype 3.0 - command and install refactoring #513
Merged
Lib from illicit part 1 #681
Merged
Hook and plugin filter extracted from lib.py #669
Merged
kalisp added a commit that referenced this issue Nov 12, 2020
@kalisp
#664 - added tests for #697
e933955
kalisp added a commit that referenced this issue Nov 12, 2020
@kalisp
#664 - added tests for #700, resolved conflicts
b238c81
kalisp added a commit that referenced this issue Nov 12, 2020
@kalisp
#664 - moved last 2 functions
5d07af2 
removed obsolete lib_old.py
kalisp added a commit that referenced this issue Nov 12, 2020
@kalisp
#664 - removed obsolete Aport action
433105e
@kalisp kalisp mentioned this issue Nov 12, 2020
Merged
mkolar added a commit that referenced this issue Nov 12, 2020
@mkolar
Merge pull request #706 from pypeclub/feature/664-3-0-lib-refactor
9640ef0 
Feature #664 3.0 lib refactor
@mkolar mkolar added the 2x-dev label Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kalisp kalisp

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
2.14.0
3 participants
@mkolar @kalisp @jakubjezek001