Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Added ability to define BG color for extract review #1088

Merged
merged 5 commits into from
Mar 9, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 3, 2021

Changes

  • it is possible to define background color with presets in ~/pype-config/presets/tools/extract_color.json
    • color must be defined with full hex color format #ffffff (e.g. #fff is not allowed)
  • output definition may have defined use_bg_color which says if should use bg color from presets- background color is used only if input's extension can have alpha channel (exr, png, dpx) for others extensions it does not make sence to even try
  • it may slow down extract review process as it must create a copy of image, fill it with color and then apply original image on top
  • same color is used for global plugin ExtractJPEG and ExtractThumbnail in standalone publisher plugins
    • there is no way how to define if should be used by extract review so use_bg_color attribute was added to have ability turn it off with presets for the plugin

Note

🏴 this depends on
pype-config ynput/pype-config#102

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 3, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 3, 2021 18:27
@mkolar mkolar added this to the 2.15.4 milestone Mar 3, 2021
@mkolar mkolar added sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality labels Mar 3, 2021
@mkolar
Copy link
Member

mkolar commented Mar 3, 2021

It's working well, however, we should probably make it work also for thumbnails, especially in standalone publisher. It is quite confusing to have a different thumbnail vs the QuickTime itself.

@mkolar mkolar merged commit 56f5fdd into 2.x/develop Mar 9, 2021
@mkolar mkolar deleted the feature/1003-choose-color-for-alpha-in-previews branch March 12, 2021 16:04
@mkolar mkolar added the 2x-dev label Mar 12, 2021
@mkolar mkolar modified the milestones: 2.15.4, 2.16.0 Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants