Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: deadline submit limit group filter #1167

Merged

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Mar 19, 2021

Description

Implementation of the Limits group attribute for submission in the JobInfo Payload attributes.
This feature will secure better handling the nuke plugin licensing when, for example, an user machines are working with Neat Video demo plugin and Render farm workers in a limited number of all workers are fully licensed.

Limit groups will be defined as pairs in Nuke deadline submitter presents where the key will be name of limit group and value will be a list of plugin's node class names. Thus, when a plugin uses more than one node, these will be captured and the triggered process will add the appropriate limit group to the payload jobinfo attributes.

Testing requirements:

  1. go to Deadline Monitor and open Limit panel
    image

  2. crate testing license limit groups
    image

  3. Add following lines to your pype-config\presets\plugins\nuke\publish.json

}
    "NukeSubmitDeadline": {
        "deadline_priority": 50,
        "deadline_pool": "",
        "deadline_pool_secondary": "",
        "deadline_chunk_size": 1,
        "deadline_limit_groups": {
            "test_group": ["Dissolve"],
            "test2_group": ["Noise"]
        }
    }
}
  1. add Noise node to scene (or to inside any of Group node). Add Dissolve node to scene. Or remove one of the node.

@jakubjezek001 jakubjezek001 added host: Nuke sponsored Client endorsed or requested 2x-dev labels Mar 19, 2021
@jakubjezek001 jakubjezek001 self-assigned this Mar 19, 2021
@jakubjezek001 jakubjezek001 linked an issue Mar 19, 2021 that may be closed by this pull request
@jakubjezek001 jakubjezek001 added this to the 2.16.0 milestone Mar 19, 2021
if lg_name not in captured_groups:
captured_groups.append(lg_name)

return ",".join(captured_groups)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just return the list of limit groups and rename the method to get_limit_groups.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. limiting groups doesn't match deadline naming and methods should be called as verbs ideally

if lg_name not in captured_groups:
captured_groups.append(lg_name)

return ",".join(captured_groups)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. limiting groups doesn't match deadline naming and methods should be called as verbs ideally

@mkolar mkolar self-requested a review March 22, 2021 12:43
@mkolar
Copy link
Member

mkolar commented Mar 22, 2021

Thanks for the fixes. Merging now, so we can push 2.16 soon, but will need 3.0 equivalent of course.

@mkolar mkolar merged commit 3c8e2b1 into 2.x/develop Mar 22, 2021
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Mar 22, 2021
@mkolar mkolar changed the title Nuke: deadline submit limiting group filter Nuke: deadline submit limit group filter Mar 22, 2021
@mkolar mkolar deleted the 2_x/feature/1164-nuke-deadline-submit-limiting-group-filter branch March 22, 2021 21:26
jakubjezek001 added a commit that referenced this pull request Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Nuke sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuke: deadline submit limiting group filter
3 participants