This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
hotfix/Fix event server mongo uri #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tokejepsen
commented
Jun 23, 2020
tokejepsen
commented
- collection name in uri creates a bad database name error
- uri was not composed correctly
- collection name in uri creates a bad database name error - uri was not composed correctly
|
Should go to |
iLLiCiTiT
reviewed
Jun 23, 2020
| @@ -51,9 +51,8 @@ def get_ftrack_event_mongo_info(): | |||
|
|
|||
| if not _used_ftrack_url or components["database"] is None: | |||
| components["database"] = database_name | |||
| components["collection"] = collection_name | |||
There was a problem hiding this comment.
This line is required (for cases that AVALON_MONGO has collection in).
If connection won't work with collection in uri then there should be components.pop("collection", None) to be sure.
Its needed in develop though as well. |
Yes, but master is at first place, it should be hotfix because it's production breaking bug. These bugs should always be in master first (and with @mkolar git app it's automatically merged to develop too if branch name starts with |
iLLiCiTiT
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.