Isolate view on instance members.

[tokejepsen]

Resolves #367

[mkolar]

Good start, but this doesn't cover standard use case yet. A few simple tweaks would do it though.

Looking at the amount of member is too implicit, and it only deals with review that is not being attached directly to subset. So it shot workflow this would do the trick but not for assets.

I would add data["isolate"] = True to review creator so it can be controlled less magically.

extractor can then have

if (len(instance.data["setMembers"]) > 1 or instance.data["isolate"]):
            preset["isolate"] = instance.data["setMembers"]`

to support both implicit and explicit

Another thing is that isolate attributeneeds to be copied do subset underneath the review if there is one. Addingdata['isolate'] = instance.data.get('isolate')` to collect_review.py line 66 would do it.

That way it works across the board.

[mkolar]

Second common situation is when artist want's to publish review of isolated model + some surrounding area and publish multiple from the same scene. For instance here where plinth is just a help model under the main model object

In that situation, we should be isolating all the object in both sets.

[mkolar]

this is what it looks like when publishing 2 model variants with review from maya for instance

you'll end up with modelFat and modelMain both of which will have abc, ma, mov representations
isolate is ideal for these scenarios as well, because artist could publish at the same time. now they have to switch visibility by hand when making multiple variants from the same scene

[tokejepsen]

I would add data["isolate"] = True to review creator so it can be controlled less magically.

Think this is a good idea as the sole indicator for whether to isolate or not. I would go as far as nothing implicitly assumed except for backwards compatibility, so no member query.

Another thing is that isolate attributeneeds to be copied do subset underneath the review if there is one. Addingdata['isolate'] = instance.data.get('isolate')` to collect_review.py line 66 would do it.

I dont quite get why it needs to be copied to instance below?

Second common situation is when artist want's to publish review of isolated model + some surrounding area and publish multiple from the same scene. For instance here where plinth is just a help model under the main model object

Just testing this and it works with the current code. Child objectsets gets correctly isolated.

[mkolar]

I don't quite get why it needs to be copied to the instance below?

because when using this workflow (attaching review to another subset), the review subset itself get's deleted at the end of the collection and its relevant data is being passed to the main subset that it's being attached to. If we don't copy the attribute to the instance below, it won't get isolated.

I"ll try again, but with all my tests, this wasn't working.

[tokejepsen]

Let me know how the testing goes.

Any thoughts on just using isolate attribute explicitly, rather than any implicit behaviour?

[mkolar]

Any thoughts on just using isolate attribute explicitly, rather than any implicit behaviour?

I'm always for explicit. So absolutely. I'd drop the implicit behaviour completely.

[tokejepsen]

I'm always for explicit. So absolutely. I'd drop the implicit behaviour completely.

Done

[mkolar]

Thanks.

The attribute works fine now, however, it still needs this

Another thing is that isolate attributeneeds to be copied do subset underneath the review if there is one. Addingdata['isolate'] = instance.data.get('isolate')` to collect_review.py line 66 would do it.

without copying the isolate attribute to the subset inside the review set, it will not isolate the subset that the review is being attached to. I"ve tested it multiple times.

[tokejepsen]

without copying the isolate attribute to the subset inside the review set, it will not isolate the subset that the review is being attached to. I"ve tested it multiple times.

Done

[mkolar]

resolves #367