Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Intent publish setting wasn't working with default value #562

Merged
merged 5 commits into from
Oct 5, 2020

Conversation

iLLiCiTiT
Copy link
Member

Issue

  • intent value is not set to context until Intent combobox change index of selected item
  • burnin use intent label even if intent value is not valid

Changes

  • intent is set all the time on play and validate buttons click
  • extract burnin checks in intent value is valid before setting intent label to burnins data

@iLLiCiTiT iLLiCiTiT self-assigned this Sep 24, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team September 24, 2020 14:28
@mkolar mkolar added the type: bug Something isn't working label Oct 1, 2020
@mkolar mkolar added this to the 2.13 milestone Oct 1, 2020
@mkolar mkolar changed the title Intent value setting in pyblish pype Intent publisch setting wasn't working with default value Oct 1, 2020
@mkolar mkolar changed the title Intent publisch setting wasn't working with default value Intent publish setting wasn't working with default value Oct 1, 2020
@mkolar
Copy link
Member

mkolar commented Oct 1, 2020

with this setting
image
I'm getting this burning if I don't select intent.
image

I reckon if the key is an empty string (so we can technically have empty default, with label acting as combo box title). I can of course do - as default key and empty string as the label, but an empty combo-box doesn't really give much of an indication to the artist.

@mkolar
Copy link
Member

mkolar commented Oct 1, 2020

Actually if I leave empty string as intent label. I get N/A in the burning that should just send empty string to the burnins.

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last thing considering we are already digging into it. There is currently no way to force an order onto the intent items. so if using empty item as default it actually pops to a second place.

@iLLiCiTiT
Copy link
Member Author

Actually if I leave empty string as intent label. I get N/A in the burning that should just send empty string to the burnins.

This should be fixed now.

There is currently no way to force an order onto the intent items. so if using empty item as default it actually pops to a second place.

True, not hard to implement and I can do that. But there's not an item in settings gui that can do that (at this time).

// Expected data stored in settings
{
    "items": [
        {"": "Intent"},
        {"wip": "WIP"},
        {"test": "TEST"},
        {"final": "FINAL"}
    ],
    "default": ""
}

@mkolar mkolar merged commit f9a3fa8 into 2.x/develop Oct 5, 2020
@mkolar mkolar deleted the bugfix/intent_value_setting branch October 6, 2020 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants