This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Store task types in the database #572
Merged
+335
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasks in project config or on assets were stored only as names. This changes them into dictionaries to enhance information that could be stored and used elsewhere later.
Changed both for config ("tasks":{TYPE: {"short_name":""}}) and assets
("tasks": {"TASK_NAME": {"type":config.tasks.TYPE}})
Modifications based on change
Modifications based on change
Revert unwanted merge
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| for tt in task_types: | ||
| tasks[tt["name"]] = { | ||
| "short_name": get_task_short_name(tt["name"]) | ||
| } |
There was a problem hiding this comment.
continuation line over-indented for hanging indent
This was referenced Sep 29, 2020
|
the resetting query needs to be to completely wipe the tasks, otherwise the sync fails |
|
the last thing that seems to be blocking this is broken workfiles app after the change |
|
I don't think that Workfile Save as is result of this change, see ynput/avalon-core@c5cc6e1 (error message sent: AttributeError: 'list' object has no attribute 'clear') I found some issues when creating completely new DB though, fixed them. |
|
you're right, it was because this branch was not up to date with develop. |
mkolar
changed the base branch from
feature/180-Store_task_types
to
2.x/develop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creation of broken PR #516
Solves: pypeclub/pype/#180
Currently task info is stored in both project config and assets as list of task names only. This PR enhances it to list of dictionaries.
I kept both config and asset as LISTs to follow getavalon/core#556 and it felt wrong to have
project.config.tasksas a dictionary and `asset.tasks' as a list.Schemas already expect list of dictionaries, so no change is needed there.
(Could be changed easily if necessary.)
I added task name to short_name mapping. This short_name could be used in paths.. in the future.
Changed do dictionaries.
Asset
Changed everywhere I could find that it should be changed.
Please test it in Nuke. (Maya and Clockify seems fine.)
Inventory app is not showing anything in Maya, but I don't think its a result of this change.
Requires:
pype-config:ynput/pype-config#81
avalon-core:ynput/avalon-core#196
Resetting queries: (EDIT)
db.getCollection('YOUR_COLLECTION_NAME').updateMany({type:"project"}, {$unset: {"config.tasks":""}})
db.getCollection('YOUR_COLLECTION_NAME').updateMany({type:"asset"}, {$unset: {"data.tasks": ""}})