Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Deadline user defaults to pype username if present #607

Merged
merged 4 commits into from
Oct 6, 2020
Merged

Deadline user defaults to pype username if present #607

merged 4 commits into from
Oct 6, 2020

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 5, 2020 •
edited
Loading

Changes

  • deadline publish should publish with right user on deadline
    • PYPE_USERNAME variable is filled on deadline submit

Note

  • not tested as don't have deadline setup

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 5, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team October 5, 2020 20:00
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Oct 6, 2020
@mkolar mkolar changed the title Keep username on deadline publish Deadline user defaults to pype username if present Oct 6, 2020
@mkolar mkolar added this to the 2.13 milestone Oct 6, 2020
@mkolar
Copy link
Member

mkolar commented Oct 6, 2020

had to add the username to deadline job payload, but other than that it worked as expected. Now burnins and deadline user itself reflect pype username if it's set

@mkolar mkolar merged commit b999775 into 2.x/develop Oct 6, 2020
@mkolar mkolar deleted the feature/publish_user_on_deadline branch October 6, 2020 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar