This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Harmony: Javascript refactoring and overall stability improvements #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_rigging_tools.js
Show resolved
Hide resolved
pype/vendor/OpenHarmony/tools/OpenHarmony_basic/openHarmony_anim_tools.js
Show resolved
Hide resolved
| return; | ||
| } | ||
|
|
||
| var install_detail_script = oh_install + "/" + item["name"]; |
There was a problem hiding this comment.
['name'] is better written in dot notation.
|
|
||
| var item = m.getItem(); | ||
| if( !item ){ | ||
| $.debug( "Failed to install - no item seems to be selected.", $.DEBUG_LEVEL["ERROR"] ); |
There was a problem hiding this comment.
['ERROR'] is better written in dot notation.
| this.basePath = ''; | ||
|
|
||
| this.removeAction = function( ev ){ | ||
| with( context.$.global ){ |
| $.debug( err + " ("+err.fileName+" "+err.lineNumber+")", $.DEBUG_LEVEL["ERROR"] ); | ||
| } | ||
| } | ||
| } |
|
|
||
| m.get_tools(); | ||
| }catch(err){ | ||
| $.debug( err + " ("+err.fileName+" "+err.lineNumber+")", $.DEBUG_LEVEL["ERROR"] ); |
There was a problem hiding this comment.
'$' used out of scope.
['ERROR'] is better written in dot notation.
| //---------------------------------------------- | ||
| //-- FILES ARE DOWNLOADED | ||
| this.downloadFiles = function( file_download_listing, overwrite ){ | ||
| with( context.$.global ){ |
| } | ||
|
|
||
| return true; | ||
| } |
| var library_base = install_base + '/openHarmony'; | ||
|
|
||
| var libdir = new Dir(library_base); | ||
| var label = new Label; |
There was a problem hiding this comment.
Missing '()' invoking a constructor.
| //-- STANDARD DIALO CONFIRMATION | ||
| this.confirmDialog = function( d_title, d_str, ok_text, cancel_text ){ | ||
| if (typeof ok_text === 'undefined') var ok_text = "Okay"; | ||
| if (typeof cancel_text === 'undefined') var cancel_text = "Cancel"; |
| //---------------------------------------------- | ||
| //-- STANDARD DIALO CONFIRMATION | ||
| this.confirmDialog = function( d_title, d_str, ok_text, cancel_text ){ | ||
| if (typeof ok_text === 'undefined') var ok_text = "Okay"; |
mkolar
approved these changes
Nov 5, 2020
mkolar
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Apart of changes described in ynput/avalon-core#211 this builds on them. It is moving all javascript code from python files to their separate js files to ease development.
Those can by found under
pype/hosts/harmony/jsand are organized in similar way as plugins are. Main object isPypeHarmony. As Pype is initialized inside Harmony, all js files are send to Harmony in one batch, evaluated there in global scope. DOM is then like this:it is up to plugin code to inject into proper attribute -
PypeHarmony.Loadersfor loaders,PypeHarmony.Creatorsfor creators andPypeHarmony.Publishfor all other (collectors, extractors, integrators, validators, ...)It incorporates many changes proposed by @karmakat.
Dependencies