Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Camera name can be added to burnins. #674

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • camera name in maya is collected and added to representation data
  • extract burnin add camera name to burnin data

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 30, 2020
@@ -110,6 +110,9 @@ def process(self, instance):
if not instance.data.get("keepImages"):
tags.append("delete")

# Add camera node name to representation data
camera_node_name = pm.ls(camera)[0].nodeName()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is right way how to get the name.
Also not sure if this is right plugin to do this, was thinking that this may be done in Collect Review Data where camera is collected to instance data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you actually don't have to do this at all. camera name is already collected in the instance. you just need to grab it and use it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you just need to grab it and use it.

Do it, please :)

@iLLiCiTiT iLLiCiTiT added 2x-dev type: enhancement Enhancements to existing functionality labels Oct 30, 2020
@mkolar mkolar added this to the 2.14 milestone Oct 30, 2020
@mkolar
Copy link
Member

mkolar commented Nov 5, 2020

I fixed the collection to get camera transform instead of shape. All working good now.

@mkolar mkolar merged commit 5d54cfa into 2.x/develop Nov 5, 2020
@mkolar mkolar deleted the feature/camera_name_in_burnins branch November 9, 2020 22:10
@mkolar mkolar changed the title Camera name in burnins Maya: Camera name can be added to burnins. Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants