This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Feature #664 3.0 lib refactor #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook and plugin filter extracted from lib.py
… into feature/664-3-0-lib-refactor
Lib from illicit part 1
…eclub/pype into feature/664-3-0-lib-refactor
…only place where is used
… into feature/664-3-0-lib-refactor
removed obsolete lib_old.py
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 11, in
sys.exit(main())
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.6/ast.py", line 253, in visit
return visitor(node)
File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
self.visit(item)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
self.visit(value)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
|
Conflict is that 2.x/develop still contain lib.py that should be removed and then merged. |
Better way is to merge 2.x/develop to this branch, Delete the lib.py and then this will be mergeable |
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 11, in
sys.exit(main())
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.6/ast.py", line 253, in visit
return visitor(node)
File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
self.visit(item)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
self.visit(value)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
|
Conflict resolved |
mkolar
approved these changes
Nov 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains multiple merged PR restructuring monolith of lib.py into separate files in
libfolder.Small grooming, no logical changes done.
Closes #664