Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Sort instances by label in pyblish gui #719

Merged
merged 5 commits into from
Nov 17, 2020

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • context item is not under any group item - possible since we don't have artist view anymore
  • items in instance view are sorted except context item which is always at the top
  • this change does not affect order of processing

image

Resolves #696

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 17, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team November 17, 2020 16:41
@mkolar mkolar added this to the 2.14 milestone Nov 17, 2020
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Nov 17, 2020
@mkolar
Copy link
Member

mkolar commented Nov 17, 2020

This is not great actually. It also sorts the plugins on the right side, which makes is super confusing to see what's going on, considering they are processed in different order, that how they are displayed.

The instances mismatch between visual ordering and processing is only a bit annoying, so I'd accept that, but the plugins are not usable.

@mkolar mkolar modified the milestones: 2.14, 2.15 Nov 17, 2020
@iLLiCiTiT
Copy link
Member Author

It also sorts the plugins on the right side, which makes is super confusing to see what's going on, considering they are processed in different order, that how they are displayed.

Good spot I actually didn't realize that.

@mkolar
Copy link
Member

mkolar commented Nov 17, 2020

Much better. thanks

@mkolar mkolar modified the milestones: 2.15, 2.14 Nov 17, 2020
@mkolar mkolar merged commit 850bf12 into 2.x/develop Nov 17, 2020
@mkolar mkolar added the 2x-dev label Nov 17, 2020
@mkolar mkolar deleted the feature/696-pyblish-gui-sorting-instances-by-name branch December 1, 2020 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants