Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Bugfix Hiero Review / Plate representation publish #743

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Bugfix Hiero Review / Plate representation publish #743

merged 2 commits into from
Dec 1, 2020

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Nov 24, 2020 •
edited
Loading

  • review representation sequence numbering fix
  • plate representation collecting
  • correct family definition
  • removing unused old plugins

@jakubjezek001 jakubjezek001 added type: bug Something isn't working host: Hiero labels Nov 24, 2020
@jakubjezek001 jakubjezek001 requested a review from a team November 24, 2020 16:26
@jakubjezek001 jakubjezek001 self-assigned this Nov 24, 2020
@jakubjezek001 jakubjezek001 force-pushed the bugfix/hiero-review-sequence-numbers branch from 447b36b to ee866c4 Compare November 24, 2020 16:30
mkolar
mkolar suggested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another bug discovered. Currently it is not possible to user the same source clip in two different shots, because it will fail on burnin extractor. The first shot creates burnin, deletes the temp clip from extra review and the following shots have nothing to work with.

We should probably use the shot name instead of source name for the temporary .movs that are fed to extract burnin.

@mkolar
Copy link
Member

mkolar commented Nov 30, 2020

We should probably use the shot name instead of source name for the temporary .movs that are fed to extract burnin.

Looks like this was caused by mixing old and new workflow, which is unsupported in the re-worked hiero workflow anyways, so I'm happy to merge this

@jakubjezek001
Copy link
Member Author

awesome, but this PR is labeled as changes requested so what to do now?

@mkolar mkolar self-requested a review December 1, 2020 14:43
@mkolar mkolar merged commit 1690cba into feature/611-simplify-hiero-tag-workflow Dec 1, 2020
@mkolar mkolar deleted the bugfix/hiero-review-sequence-numbers branch December 1, 2020 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar Awaiting requested review from mkolar

Assignees

@jakubjezek001 jakubjezek001

Labels
host: Hiero type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubjezek001 @mkolar