Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings required keys in modifiable dict #770

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Settings required keys in modifiable dict #770

merged 4 commits into from
Dec 2, 2020

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • item modifiable-dict may have defined required keys
  • required keys must be defined as a list (e.g. ["key_1"])
    • they are moved to the top
  • these keys can't be removed or edited (even for developer)
    • it is possible to edit label if item is collapsible

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 2, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team December 2, 2020 12:07
@mkolar mkolar added this to the 3.0 milestone Dec 2, 2020
@mkolar mkolar added backend type: enhancement Enhancements to existing functionality and removed backend labels Dec 2, 2020
@mkolar mkolar merged commit d4744c1 into 2.x/develop Dec 2, 2020
@mkolar mkolar deleted the feature/required_keys_modifiable_dict branch December 4, 2020 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
3.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar