Add filesize limit help link to error message

Author: brainwane

tests/unit/forklift/test_legacy.py

@@ -1540,15 +1540,22 @@ def test_upload_fails_with_too_large_file(self, pyramid_config,
                 type="application/tar",
             ),
         })
+        db_request.route_url = pretend.call_recorder(
+            lambda route, **kw: "/the/help/url/"
+        )
 
         with pytest.raises(HTTPBadRequest) as excinfo:
             legacy.file_upload(db_request)
 
         resp = excinfo.value
 
+        assert db_request.route_url.calls == [
+            pretend.call('help', _anchor='file-size-limit')
+        ]
         assert resp.status_code == 400
         assert resp.status == (
-            "400 File too large. Limit for project 'foobar' is 60MB"
+            "400 File too large. Limit for project 'foobar' is 60MB. "
+            "See /the/help/url/"
         )
 
     def test_upload_fails_with_too_large_signature(self, pyramid_config,

warehouse/forklift/legacy.py

@@ -993,10 +993,14 @@ def file_upload(request):
                     raise _exc_with_message(
                         HTTPBadRequest,
                         "File too large. " +
-                        "Limit for project {name!r} is {limit}MB".format(
+                        "Limit for project {name!r} is {limit}MB. ".format(
                             name=project.name,
-                            limit=file_size_limit // (1024 * 1024),
-                        ))
+                            limit=file_size_limit // (1024 * 1024)) +
+                        "See " +
+                        request.route_url(
+                            'help', _anchor='file-size-limit'
+                        ),
+                    )
                 fp.write(chunk)
                 for hasher in file_hashes.values():
                     hasher.update(chunk)