Advise packagers on requesting upload size limit increase (#3175)

* Advise packagers on requesting upload size limit increase

* Add filesize limit help link to error message

* Fix typo in comment

Author: brainwane

tests/unit/forklift/test_legacy.py

@@ -1548,15 +1548,22 @@ def test_upload_fails_with_too_large_file(self, pyramid_config,
                 type="application/tar",
             ),
         })
+        db_request.route_url = pretend.call_recorder(
+            lambda route, **kw: "/the/help/url/"
+        )
 
         with pytest.raises(HTTPBadRequest) as excinfo:
             legacy.file_upload(db_request)
 
         resp = excinfo.value
 
+        assert db_request.route_url.calls == [
+            pretend.call('help', _anchor='file-size-limit')
+        ]
         assert resp.status_code == 400
         assert resp.status == (
-            "400 File too large. Limit for project 'foobar' is 60MB"
+            "400 File too large. Limit for project 'foobar' is 60MB. "
+            "See /the/help/url/"
         )
 
     def test_upload_fails_with_too_large_signature(self, pyramid_config,

warehouse/forklift/legacy.py

@@ -966,7 +966,7 @@ def file_upload(request):
             request.POST["content"].type.startswith("image/")):
         raise _exc_with_message(HTTPBadRequest, "Invalid distribution file.")
 
-    # Ensure that the package filetpye is allowed.
+    # Ensure that the package filetype is allowed.
     # TODO: Once PEP 527 is completely implemented we should be able to delete
     #       this and just move it into the form itself.
     if (not project.allow_legacy_files and
@@ -997,10 +997,14 @@ def file_upload(request):
                     raise _exc_with_message(
                         HTTPBadRequest,
                         "File too large. " +
-                        "Limit for project {name!r} is {limit}MB".format(
+                        "Limit for project {name!r} is {limit}MB. ".format(
                             name=project.name,
-                            limit=file_size_limit // (1024 * 1024),
-                        ))
+                            limit=file_size_limit // (1024 * 1024)) +
+                        "See " +
+                        request.route_url(
+                            'help', _anchor='file-size-limit'
+                        ),
+                    )
                 fp.write(chunk)
                 for hasher in file_hashes.values():
                     hasher.update(chunk)

warehouse/templates/pages/help.html

@@ -30,6 +30,7 @@
 {% macro preproduction() %}What does pre-production mean?{% endmacro %}
 {% macro project_name() %}Why isn't my desired project name available?{% endmacro %}
 {% macro project_name_claim() %}How do I claim an abandoned or previously registered project name?{% endmacro %}
+{% macro file_size_limit() %}How do I get a file size limit exemption or increase for my project?{% endmacro %}
 {% macro verified_email() %}Why do I need a verified email address?{% endmacro %}
 {% macro maintainers() %}Who maintains PyPI?{% endmacro %}
 {% macro sponsors() %}What powers PyPI?{% endmacro %}
@@ -54,6 +55,7 @@ <h1 class="page-title">Common Questions</h1>
         <li><a href="#preproduction">{{ preproduction() }}</a></li>
         <li><a href="#project-name">{{ project_name() }}</a></li>
         <li><a href="#project-name-claim">{{ project_name_claim() }}</a></li>
+        <li><a href="#file-size-limit">{{ file_size_limit() }}</a></li>
         <li><a href="#verified-email">{{ verified_email() }}</a></li>
         <li><a href="#maintainers">{{ maintainers() }}</a></li>
         <li><a href="#accessibility">{{ accessibility() }}</a></li>
@@ -154,6 +156,17 @@ <h2>{{ project_name_claim() }}</h2>
         </p>
       </section>
 
+      <section id="file-size-limit" class="common-question">
+        <h2>{{ file_size_limit() }}</h2>
+        <p>
+          If you can't upload your project's release to PyPI because you're hitting the upload file size limit, we can sometimes increase your limit. Please make sure you've uploaded at least one release for the project that's <i>under</i> the limit (a <a href="https://www.python.org/dev/peps/pep-0440/#developmental-releases">developmental release version number</a> is fine). Then, please <a href="https://github.com/pypa/warehouse/issues/new">file an issue</a> and tell us:</p>
+        <ul>
+          <li>The name of the project</li>
+          <li>The size of your release, in megabytes</li>
+          <li>Which index/indexes you need the increase for (PyPI, Test PyPI, or both)</li>
+        </ul>
+      </section>
+
       <section id="verified-email" class="common-question">
         <h2>{{ verified_email() }}</h2>
         <p>