feat: enable pending gitlab publisher reinfication

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

Author: miketheman

tests/unit/oidc/models/test_gitlab.py

@@ -937,3 +937,13 @@ def test_reify_already_exists(self, db_request):
         # it is returned and the pending publisher is marked for deletion.
         assert existing_publisher == publisher
         assert pending_publisher in db_request.db.deleted
+
+    def test_reify_with_custom_issuer_url(self, db_request):
+        custom_issuer_url = "https://gitlab.custom-domain.com"
+        pending_publisher = PendingGitLabPublisherFactory.create(
+            issuer_url=custom_issuer_url
+        )
+        publisher = pending_publisher.reify(db_request.db)
+
+        assert publisher.issuer_url == custom_issuer_url
+        assert isinstance(publisher, gitlab.GitLabPublisher)

warehouse/oidc/models/gitlab.py

@@ -435,8 +435,7 @@ def reify(self, session: Session) -> GitLabPublisher:
                 GitLabPublisher.project == self.project,
                 GitLabPublisher.workflow_filepath == self.workflow_filepath,
                 GitLabPublisher.environment == self.environment,
-                # TODO (glsm): Implement custom issuers
-                #  GitLabPublisher.issuer_url == self.issuer_url,
+                GitLabPublisher.issuer_url == self.issuer_url,
             )
             .one_or_none()
         )
@@ -446,8 +445,7 @@ def reify(self, session: Session) -> GitLabPublisher:
             project=self.project,
             workflow_filepath=self.workflow_filepath,
             environment=self.environment,
-            # TODO (glsm): Implement custom issuers
-            #  issuer_url=self.issuer_url,
+            issuer_url=self.issuer_url,
         )
 
         session.delete(self)