Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 592 -- Yanking of Releases/Files #5837

Closed
dstufft opened this issue May 12, 2019 · 13 comments
Closed

Implement PEP 592 -- Yanking of Releases/Files #5837

dstufft opened this issue May 12, 2019 · 13 comments
Labels
feature request help needed We'd love volunteers to advise on or help fix/implement this.

Comments

@dstufft
Copy link
Member

dstufft commented May 12, 2019

The way we should implement this is that an entire release can be yanked or unyanked at will by a maintainer of a project. Yanking should set an attribute on the simple repository link for any files for that release.

@dstufft
Copy link
Member Author

dstufft commented May 12, 2019

Here's a PR that starts implementing this #5838.

@brainwane
Copy link
Contributor

Hey @dstufft -- I think I may be misunderstanding something. In our discussion in March we discussed wanting a system for generic flags and statuses on projects and releases, in order to address #345 "Ability to mark a version of a package as deprecated or unsupported" and #3709 "Offer a discouraged/deprecated releases option", and to help with future moderation work on stuff like #6062 re: malware/spam detection.

Will the yanking feature address either of those "mark package as deprecated" issues?

And: are you planning on implementing the "yanked" attribute within a generic flags/statuses system? If not then I should file an issue to start speccing that out.

Also, I figure yanking will constitute an event that should be listed in #5863, so, linking to that issue.

@brainwane
Copy link
Contributor

And is #4962 potentially relevant?

@cjerdonek
Copy link

For reference purposes, I just wanted to note on this issue that PEP 592 support has been added to pip and will be in its next release: pypa/pip#6633

@di
Copy link
Member

di commented Jul 30, 2019

In #6318, @ncoghlan asked that the "delete project/release" dialog to include

an easy way to yank every released version instead (preferably as one of the options in the warning notice)

Ideally implementing this PR would include such a link/notice/feature.

@pradyunsg
Copy link
Contributor

Will the yanking feature address either of those "mark package as deprecated" issues?

Yep, for both issues. #4962 doesn't seem relevant to me.

@brainwane
Copy link
Contributor

@ewdurbin See pypa/pip#7621 (comment) for why this might be a feature to prioritize in Warehouse.

@brainwane brainwane added the help needed We'd love volunteers to advise on or help fix/implement this. label Jan 27, 2020
@brainwane
Copy link
Contributor

Per #5838 (comment) , we'd like help with this. Donald wrote part of a pull request to implement this, and said,

I am unlikely to find time in the interim to finish this, though I think we could deploy this without an API and just have it be a UI only feature for now.

This feature would be helpful in improving pip's release process, so it would be great if a volunteer could step up and finish this WIP within the next couple of months.

@brainwane
Copy link
Contributor

@di @dstufft can you advise on whether this feature is likely to get into Warehouse within the next few months?

@dstufft
Copy link
Member Author

dstufft commented Apr 2, 2020

I am unlikely to find time in the next few months to work on it.

@di
Copy link
Member

di commented Apr 2, 2020

Seems likely. In my opinion #5838 is now complete and just waiting to be reviewed.

@di
Copy link
Member

di commented Apr 22, 2020

Fixed in #5838.

@brainwane
Copy link
Contributor

The release yanking feature is now live on PyPI and the "yanked" field is now available in the API. @ori-yitzhaki and @yuvalreches you'll probably want to test this with JFrog Artifactory and verify that you are properly using "yanked" status when appropriate. If you find a bug in PyPI's implementation, please file it as a new issue and link to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request help needed We'd love volunteers to advise on or help fix/implement this.
Projects
None yet
Development

No branches or pull requests

5 participants