Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parenthesis error in deprecation docs #8031

Closed
brainwane opened this issue Jun 2, 2020 · 6 comments · Fixed by #8046
Closed

fix parenthesis error in deprecation docs #8031

brainwane opened this issue Jun 2, 2020 · 6 comments · Fixed by #8046
Labels
documentation good first issue This issue is ideal for first-time contributors!

Comments

@brainwane
Copy link
Contributor

I'd like for @Manthan03583 to take this one.

https://warehouse.readthedocs.io/application/#historical-context-deprecations has a grammar error in the line

download counts visible in the API: instead, use the Google BigQuery service)

This is a good first contribution for someone who's new to this repository. You open up docs/application.rst and change

- `download counts visible in the API <https://warehouse.readthedocs.io/api-reference/xml-rpc/#changes-to-legacy-api>`_:
  instead, use `the Google BigQuery service <https://packaging.python.org/guides/analyzing-pypi-package-downloads/>`_)

to

- `download counts visible in the API <https://warehouse.readthedocs.io/api-reference/xml-rpc/#changes-to-legacy-api>`_
  (instead, use `the Google BigQuery service <https://packaging.python.org/guides/analyzing-pypi-package-downloads/>`_)

and then open a pull request.

--

Good First Issue for @Manthan03583: For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, feel free to ask them here, #pypa-dev on Freenode, or the distutils-sig.python.org mailing list.

@brainwane brainwane added good first issue This issue is ideal for first-time contributors! documentation labels Jun 2, 2020
@Manthan03583
Copy link
Contributor

Thank you

@Manthan03583
Copy link
Contributor

mailing list link in developer docs updated #8030

@brainwane
Copy link
Contributor Author

Hi @Manthan03583 - please come into IRC https://webchat.freenode.net/?channels=%23pypa-dev now, if you can.

@Manthan03583
Copy link
Contributor

Manthan03583 commented Jun 2, 2020

sorry mam , my internet connection is running slowly now. And I am sorry because i mixed both the commits in one pull request.#8030

@brainwane
Copy link
Contributor Author

@Manthan03583

I think you need some basic help using git before you continue. Instead of committing your proposed changes to your master branch, you need to create a new branch and commit the changes to that new branch. I suggest that you read a training kit from

https://github.github.com/training-kit/ (available in several languages)

from start to finish, and that you read

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/proposing-changes-to-your-work-with-pull-requests

as well. This will probably take you a few days. If you need some more guidance to understand how to make a new branch and create a pull request from it, please take a look at https://zulip.readthedocs.io/en/latest/git/ which may also help you.

Then, after you've done that, please open a new PR in this repository, one that just contains bbeb7d1 .

Thanks.

@Manthan03583
Copy link
Contributor

parenthesis error in deprecation docs fixed #8046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation good first issue This issue is ideal for first-time contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants