Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mask=False for backend MaskedDistribution #459

Open
fehiepsi opened this issue Feb 9, 2021 · 0 comments
Open

Support mask=False for backend MaskedDistribution #459

fehiepsi opened this issue Feb 9, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@fehiepsi
Copy link
Member

fehiepsi commented Feb 9, 2021

Currently, when converting masked distribution to funsor, we cast the boolean mask to float and multiply the mask array with the base dist. It would be nice if we can leverage the boolean mask to avoid some computations when mask=False. I guess in that case, we can return a zero Tensor with shapes are interpreted from the backend masked distribution.

@fehiepsi fehiepsi added the enhancement New feature or request label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant