Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Default Front and Back Tensions #242

Closed
ChRen95 opened this issue Aug 22, 2024 · 2 comments · Fixed by #245
Closed

Add Default Front and Back Tensions #242

ChRen95 opened this issue Aug 22, 2024 · 2 comments · Fixed by #245
Assignees
@axtimhaus @ChRen95 @RichardPfr
Labels
enhancement New feature or request

Comments

@ChRen95
Copy link
Member

ChRen95 commented Aug 22, 2024

Summary

Since we want to provide algorithms for the calculation of tensions in between roll passes, default values for the front_tension and back_tension are needed. I would suggest we provide them as 0 in the hookimpls.
This would add the concept of having a tension free process to the core.
Approving @axtimhaus @RichardPfr ?
@ChRen95 ChRen95 added the enhancement New feature or request label Aug 22, 2024
@axtimhaus
Copy link
Member

Seems reasonable

@RichardPfr
Copy link
Contributor

Yes seems good

@ChRen95 ChRen95 linked a pull request Aug 22, 2024 that will close this issue
added default tensions #245
Merged
@ChRen95 ChRen95 mentioned this issue Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axtimhaus axtimhaus

@ChRen95 ChRen95

@RichardPfr RichardPfr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added default tensions pyroll-project/pyroll-core
3 participants
@axtimhaus @ChRen95 @RichardPfr