Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Move Dimension/Measure type from description #64

Open
norbertbede opened this issue Apr 14, 2020 · 6 comments
Open

Move Dimension/Measure type from description #64

norbertbede opened this issue Apr 14, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@norbertbede
Copy link

Is your feature request related to a problem? Please describe.
We need description field for serious dimension and measure description explain users useful informations. ATM description is used for differentiate

Describe the solution you'd like
Opt1. extend table metabase_field column name eg.

  • dimension.Warehouse.linecount
  • measure.Warehouse.docdate

Opt2. extend field metabase_field.fingertip column
With a small luck json should be extendable and not dis-function metabase basic functionality.

Notes
ATM i disagree with issue: Idea: store the measures only in metrics #50
reason: we are dealing with get work basic measures for simple calculation and/or relative offset of measure - eg. get past month for same measure. (custom metric) - i will explain it soon in another issue.

@pyrooka
Copy link
Owner

pyrooka commented Apr 16, 2020

Yes, I have already thought about it. As far as I remember, I tried once to add this information to a custom field but it didn't work.
So we have to investigate where can we store the details without breaking the Metabase.

@norbertbede
Copy link
Author

did you try opt1 or opt2 - described above ?
can you elaborate to describe you approach ?

@pyrooka
Copy link
Owner

pyrooka commented Apr 17, 2020

I tried to add an extra field to the Field model, but that made it invalid.
The first one could work but I don't really like the idea to "pollute" the name of the field with the type. In this case, we should leave the field type in the description. For example: "measure; This is the field comment.". But store this info in a separate field, hidden from the user would be the best solution in my opinion.

@pyrooka pyrooka added the enhancement New feature or request label Apr 17, 2020
@pyrooka pyrooka self-assigned this Apr 22, 2020
@pyrooka
Copy link
Owner

pyrooka commented Apr 22, 2020

@norbertbede what do you think #70 ?

@norbertbede
Copy link
Author

for now, can be acceptable. the question is what happening when admin forget or make mistake field content change.

@pyrooka
Copy link
Owner

pyrooka commented Apr 27, 2020

You mean the admin changes the field comment/description?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants