Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid package not installing submodules #51

Closed
asmodehn opened this issue Sep 8, 2016 · 2 comments
Closed

Hybrid package not installing submodules #51

asmodehn opened this issue Sep 8, 2016 · 2 comments
Labels

Comments

@asmodehn
Copy link
Member

asmodehn commented Sep 8, 2016

Not sure why, but a hybrid package built and installed with catkin_pip seems to not install submodules... even if listed in the setup.py call as is doable for catkin...

This means that for rostful and celeros, I currently had to revert to use pure catkin to get all dependencies working correctly in install space (since they are not yet rospackaged)

We need to investigate more, but installing with catkin_pip should also install the submodules packages, so that a user can switch at his own speed from pip package(devel only), to submodule(devel / install but not clean -> should not be released ), to ros/deb pkg dependency ( from source/release repo first, then from rosdep pkg after it is released).

@asmodehn
Copy link
Member Author

  • submodules are useful to retrieve package B source when package A depends on package B which has not been adapted for ROS. the main python code for A can access the code for B via multiple ways (symlink, .pth files, etc.)
  • for the devel space, catkin_pip retrieve the pip package into the devel space, but it requires having a pip package for it. This is probably good enough (making a pip package is the python way to do things and is quite easy and quick) for the devel space.
  • for the install space, catkin_pip should probably NOT install submodules anyway, since one installed package, is supposed to contain only ONE package. Otherwise we can have another package in the same workspace, etc.
  • also if we want multiple pip packages installed inside one package on install, we need to follow the proper way to do that from python, with a virtualenv. And pip can install properly a pacakge in a virtual env, nothing special to do there.

=> Given this information, instead of trying to install git submodules, maybe we should focus on being able to deploy a full virtualenv as a ros package ?

@asmodehn
Copy link
Member Author

This is superseeded by the more general #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant