Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropping namespace package #13

Closed
asmodehn opened this issue Apr 19, 2017 · 4 comments
Closed

dropping namespace package #13

asmodehn opened this issue Apr 19, 2017 · 4 comments

Comments

@asmodehn
Copy link
Member

Although quite practical to allow us to retrieve catkin generated messages even without sourcing ROS setup, it will prevent us from making a working ROS package for this (tested with pyros-dev/pyros-common#1).

So we need to turn this into a normal package, while keeping all our usecases working :

  • from ROS (full catkin usecase)
  • from python isolated in venv (tox usecase)
  • from python on top of ROS system (PyCharm running tests on ROs machine usecase)...
@asmodehn
Copy link
Member Author

The tentative release 0.1.1 still has a namespace package definition...

@asmodehn
Copy link
Member Author

Since rosimport, the python user is expected to use it, OR the usual ROS catkin system, to generate message python code.
Therefore generating the python code is not the responsibility of this package any longer, and we should be able to drop the namespace package declaration, and everything should still work as expected.

@asmodehn
Copy link
Member Author

namespace has been dropped in #14 however this might create problems with catkin, since messages will be created in another folder (in devel and not in source), and with python2 namespace package is needed to unify both in same package...
We need to test this more.

@asmodehn
Copy link
Member Author

Closing since PR has been merged. If problems arise, they can be flagged as separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant