Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of duplicated tests setup #26

Open
asmodehn opened this issue Sep 1, 2017 · 2 comments
Open

get rid of duplicated tests setup #26

asmodehn opened this issue Sep 1, 2017 · 2 comments
Assignees

Comments

@asmodehn
Copy link
Member

asmodehn commented Sep 1, 2017

We have two main sets of requirements :

  • debs envs with:
    • dependency version based on rosdistro
    • tests dependency version based on rosdistro
  • python envs with:
    • dependency version based on rosdistro
    • latest test dependency versions (from PyPI)

Since we extracted the tests from the main package for simplicity (especially for managing backward compatiblity and pure python testing), there is probably no need to have the tests dependencies version based on rosdistro. We should be fine using latest test dependencies.
This reduces the number of dependencies for the package, and forces us to do development work in a recent python environment (as per usual python workflow).

We will lose the possibility of running tests in old environments (unless we do pyros-dev/catkin_pip#104), and we would build ros package without tests... It might not be ideal, but saves quite some time and reduces complexity, especially because we can manage testing in multiple versions easily with tox and a set of requirements...

It means, we are relying on the linux distro to provide a consistent, up-to-date, python environment. That might be "good enough", and make our lives much simpler.
ROS packages then become a backport of python packages, which is the intent anyway.

So, with that in mind, it seems we can get rid of our deb envs requirement set...

@asmodehn
Copy link
Member Author

asmodehn commented Sep 4, 2017

This should be done in #14

@asmodehn asmodehn assigned asmodehn and unassigned GTedHa Feb 13, 2018
@asmodehn
Copy link
Member Author

PR has been merged, but this still remains...
It shall be done in parallel with ROS Third party release repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants