Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add ability to delete apps #119

Closed
petethepig opened this issue Mar 11, 2021 · 1 comment · Fixed by #221
Closed

Feature: add ability to delete apps #119

petethepig opened this issue Mar 11, 2021 · 1 comment · Fixed by #221
Assignees
@AdrK
Labels
frontend Mostly JS code

Comments

@petethepig
Copy link
Member

See #118 (comment) for context
@petethepig petethepig added frontend Mostly JS code backend Mostly go code labels Mar 11, 2021
@petethepig petethepig mentioned this issue Mar 11, 2021
Closed
@AdrK AdrK linked a pull request May 27, 2021 that will close this issue
Closes: Feature: add ability to delete apps #119 #221
Merged
AdrK added a commit that referenced this issue May 27, 2021
@AdrK
Feature: add ability to delete apps #119
5d2cf25
AdrK added a commit that referenced this issue May 27, 2021
@AdrK
Feature: add ability to delete apps #119
dfbafc9
AdrK added a commit that referenced this issue May 27, 2021
@AdrK
Feature: add ability to delete apps #119
e19f7cb
AdrK added a commit that referenced this issue May 27, 2021
@AdrK
Feature: add ability to delete apps #119
8b8fe61
petethepig added a commit that referenced this issue Jun 3, 2021
@AdrK @petethepig
Closes: Feature: add ability to delete apps #119 (#221)
2cc5f0e 
* Feature: add ability to delete apps #119

* More tests

* Added proper delete, but waiting for lfu-go fork to be updated.

* Use lfu-go from fork, still temporary solution

* replaced closingMutex with a RWMutex

Co-authored-by: Dmitry Filimonov <dmitry@pyroscope.io>
@AdrK
Copy link
Contributor

AdrK commented Jun 4, 2021

There is still front end to be done, so reopening ;)

@AdrK AdrK reopened this Jun 4, 2021
@petethepig petethepig removed the backend Mostly go code label Jun 7, 2021
@Rperry2174 Rperry2174 mentioned this issue Jul 15, 2021
Closed
2 tasks
korniltsev pushed a commit that referenced this issue Jul 18, 2023
@simonswine
Merge pull request #119 from grafana/20220726_make-order-of-stacktrac…
f0da231 
…es-stable

Order stacktraces by ID to have a deterministic flamegraph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdrK AdrK

Labels
frontend Mostly JS code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes: Feature: add ability to delete apps #119 grafana/pyroscope
3 participants
@petethepig @AdrK @Rperry2174