Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement delete app functionality as an HTTP endpoint #1223

Closed
petethepig opened this issue Jul 6, 2022 · 2 comments
Closed

Implement delete app functionality as an HTTP endpoint #1223

petethepig opened this issue Jul 6, 2022 · 2 comments
Labels
backend Mostly go code

Comments

@petethepig
Copy link
Member

Currently it's only possible via the admin command.

We should add this functionality to the HTTP controller. We should make it so that it requires authentication. If there's no authentication mechanisms set up on the server it should return an error.
@petethepig petethepig added the backend Mostly go code label Jul 6, 2022
@petethepig petethepig mentioned this issue Jul 6, 2022
Closed
@eh-am
Copy link
Collaborator

eh-am commented Jul 7, 2022

Maybe we could even use the same admin server? https://github.com/pyroscope-io/pyroscope/blob/main/pkg/admin/server.go#L42

@eh-am eh-am mentioned this issue Jul 11, 2022
Merged
korniltsev added a commit that referenced this issue Jul 29, 2022
@korniltsev
feat(api): Implement delete app functionality as an HTTP endpoint bac…
b82f426 
…kend #1223  (#1239)
@petethepig
Copy link
Member Author

done in b82f426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Mostly go code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petethepig @eh-am