-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(flamegraph/models): make it mandatory to handle all spyNames #1300
Conversation
3abd196
to
7474764
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Codecov Report
@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
+ Coverage 68.52% 68.60% +0.09%
==========================================
Files 112 113 +1
Lines 3713 3726 +13
Branches 842 843 +1
==========================================
+ Hits 2544 2556 +12
- Misses 1167 1168 +1
Partials 2 2
Continue to review full report at Codecov.
|
size-limit report 📦
|
BREAKING CHANGE: if a unsupported
spyName
is received from the server, an error is thrown.Propagate
spyName
and narrow its type (now it's a union instead of a simple string).This forces us to update
spyToRegex
whenever there's an update to the spyNames list.For Example, I removed the
pyroscope-rs
andunknown
cases, then lint started barking:Also export spyNames via
SpyNameFirstClass
andSpyNameOther
, in case we want to use that info at runtime. (eg in flamegraph.com)