-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ebpf): pythonless, portable ebpf #1314
Conversation
marked as ready so that I can get a docker image |
This reverts commit 8c0942d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make the command be pyroscope ebpf
. ebpfspy is more obscure, and long term we're trying to get rid of this whole "spy" suffix.
Co-authored-by: Dmitry Filimonov <dmitry@pyroscope.io>
Co-authored-by: Dmitry Filimonov <dmitry@pyroscope.io>
Co-authored-by: Dmitry Filimonov <dmitry@pyroscope.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
In it's current state this PR:
Have been running in our cluster for the last few days and everything seems to be working great — there's no memory leaks and CPU performance overhead is currently at around 0.25%.
TODOs:
use pprof as transport format (might make it more efficient once we add labels from k8s)- decided to postpone, maybe reuse transporttrie, maybe something else