Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ebpf): pythonless, portable ebpf #1314

Merged
merged 59 commits into from
Aug 19, 2022
Merged

feat(ebpf): pythonless, portable ebpf #1314

merged 59 commits into from
Aug 19, 2022

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Jul 27, 2022

In it's current state this PR:

  • removes python dependency
  • we now compile BPF program once (CO:RE) — no longer compile BPF program each 10 seconds
  • there's no longer need for linux headers to be present on the system

Have been running in our cluster for the last few days and everything seems to be working great — there's no memory leaks and CPU performance overhead is currently at around 0.25%.

TODOs:

  • make a separate command
  • make some parameters (like symbol cache sizes) configurable
  • add labels from k8s automatically
  • use pprof as transport format (might make it more efficient once we add labels from k8s) - decided to postpone, maybe reuse transporttrie, maybe something else

@petethepig petethepig marked this pull request as ready for review July 28, 2022 04:29
@petethepig
Copy link
Member

marked as ready so that I can get a docker image

pkg/agent/ebpfspy/symbols_linux.go Outdated Show resolved Hide resolved
pkg/agent/ebpfspy/symbols_linux.go Outdated Show resolved Hide resolved
@korniltsev korniltsev changed the title WIP feat(ebpf): pythonless, portable ebpf feat(ebpf): pythonless, portable ebpf Aug 16, 2022
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make the command be pyroscope ebpf. ebpfspy is more obscure, and long term we're trying to get rid of this whole "spy" suffix.

@petethepig petethepig self-requested a review August 19, 2022 07:45
Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@petethepig petethepig merged commit f124c46 into main Aug 19, 2022
@petethepig petethepig deleted the feat/pythonless_ebpf branch August 19, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts lfs-detected! Warning Label for use when LFS is detected in the commits of a Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants