feat(webapp): update timeline appearance and refactor flot plugins #1323
Conversation
pavelpashkovsky
changed the title
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 123 123
Lines 4040 4040
Branches 930 930
=======================================
Hits 2729 2729
Misses 1307 1307
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/create-server |
|
looks like selection boundaries and overlay are too much pale. |
|
@Rperry2174, I can be wrong, but I've just remembered that you wanted to remove these captions several months ago? Should I do this?
|
| from: leftFrom, | ||
| to: leftUntil, | ||
| color: leftColor, | ||
| overlayColor: leftColor.alpha(0.3), |
There was a problem hiding this comment.
What does overLayColor correspond to? is it this
There was a problem hiding this comment.
@Rperry2174 you are right, it's visible semi transparent area between selection boundaries, you can set it's color by changing overlayColor prop
Yeah we can remove these now. Given the current way that the code is structured what would be the steps to be able to control the selection like this? |
|
/create-server |
pavelpashkovsky
force-pushed
the
timeline-refactor
branch
from
3978668 to
78a806d
Compare
|
/create-server |
|
/create-server |
2 similar comments
|
/create-server |
|
/create-server |
|
/create-server |
|
almost there! I definitely like these selectors better.. Can we make this cursor an "open" hand: |
|
@Rperry2174, I changed resize cursor to open hand, please re/create-server |
|
/create-server |
Rperry2174
changed the title
Short summary on this PR
We don't edit any code in Flot anymore. But there are cases when new functionality based on some built-in plugins. In case of upgrading time selection functionality I extracted
react-flot/flot/jquery.flot.selection.mininto a file./TimelineChartSelection, where I customised existing logic in accordance with task requirements. It's important to note, that there are 2 types of timeline selection:doubleandsingle. All customisation was applied only forsingletype of selection.Doubleworks in old fashion way (using built-in Flot selection, not plugin-built one).I also extended in a bit TimelineChartWrapper API. Now you can set colors for selection boundaries and overlay. Adding colors depending on color mode is in progress