Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use sampling ticker for resettable spies #1429

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

korniltsev
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 417.13 KB (0%) 8.4 s (0%) 3.7 s (+7.91% 🔺) 12.1 s
webapp/public/assets/app.css 14.99 KB (0%) 300 ms (0%) 0 ms (+100% 🔺) 300 ms
webapp/public/assets/styles.css 9.39 KB (0%) 188 ms (0%) 0 ms (+100% 🔺) 188 ms
packages/pyroscope-flamegraph/dist/index.js 90.77 KB (0%) 1.9 s (0%) 1.6 s (+29.24% 🔺) 3.4 s
packages/pyroscope-flamegraph/dist/index.node.js 90.64 KB (0%) 1.9 s (0%) 533 ms (-42.31% 🔽) 2.4 s
packages/pyroscope-flamegraph/dist/index.css 6.94 KB (0%) 139 ms (0%) 0 ms (+100% 🔺) 139 ms

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1429 (89fd491) into main (92e5dbe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1429   +/-   ##
=======================================
  Coverage   68.37%   68.37%           
=======================================
  Files         129      129           
  Lines        4252     4252           
  Branches     1155     1155           
=======================================
  Hits         2907     2907           
  Misses       1340     1340           
  Partials        5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -0,0 +1,57 @@
package alignedticker
Copy link
Member

@petethepig petethepig Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for implementing, we needed this!

@petethepig petethepig merged commit 6f279e4 into main Aug 22, 2022
@petethepig petethepig deleted the fix/agent_session_busy_loop2 branch August 22, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants