Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): position annotation context menu #1534

Merged
merged 24 commits into from
Sep 22, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Sep 21, 2022

Closes #1533
Kapture 2022-09-21 at 10 20 16

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 66.40% // Head: 66.40% // No change to project coverage 👍

Coverage data is based on head (2e14fa3) compared to base (740a0f7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage   66.40%   66.40%           
=======================================
  Files         147      147           
  Lines        4997     4997           
  Branches     1356     1356           
=======================================
  Hits         3318     3318           
  Misses       1674     1674           
  Partials        5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 443.54 KB (+0.02% 🔺) 8.9 s (+0.02% 🔺) 3.4 s (+7.85% 🔺) 12.3 s
webapp/public/assets/app.css 17.02 KB (0%) 341 ms (0%) 0 ms (+100% 🔺) 341 ms
webapp/public/assets/styles.css 9.49 KB (0%) 190 ms (0%) 0 ms (+100% 🔺) 190 ms
packages/pyroscope-flamegraph/dist/index.js 92.09 KB (0%) 1.9 s (0%) 1.3 s (-15.51% 🔽) 3.2 s
packages/pyroscope-flamegraph/dist/index.node.js 91.98 KB (0%) 1.9 s (0%) 557 ms (-17.27% 🔽) 2.4 s
packages/pyroscope-flamegraph/dist/index.css 7.32 KB (0%) 147 ms (0%) 0 ms (+100% 🔺) 147 ms

@eh-am eh-am marked this pull request as ready for review September 22, 2022 12:30
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- added one comment about threshold variable

@eh-am eh-am merged commit 0ce4e7d into main Sep 22, 2022
@eh-am eh-am deleted the fix/position-annotation-context-menu branch September 22, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle "New Annotation" popover off window positioning
2 participants