Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heatmap small fixes #1545

Merged
merged 3 commits into from
Sep 26, 2022
Merged

fix: heatmap small fixes #1545

merged 3 commits into from
Sep 26, 2022

Conversation

dogfrogfog
Copy link
Contributor

@dogfrogfog dogfrogfog commented Sep 26, 2022

Brief

Changes

  • fix heatmap test warning
  • fix 404 error after /exemplars/single, /exemplars/merge pages reload
  • add ability to start selection from already drawn selected area
heatmap.mov

Concerns

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 443.6 KB (+0.01% 🔺) 8.9 s (+0.01% 🔺) 4.8 s (+18.51% 🔺) 13.7 s
webapp/public/assets/app.css 17.08 KB (0%) 342 ms (0%) 0 ms (+100% 🔺) 342 ms
webapp/public/assets/styles.css 9.49 KB (0%) 190 ms (0%) 0 ms (+100% 🔺) 190 ms
packages/pyroscope-flamegraph/dist/index.js 92.16 KB (0%) 1.9 s (0%) 1.2 s (+1.2% 🔺) 3.1 s
packages/pyroscope-flamegraph/dist/index.node.js 92.05 KB (0%) 1.9 s (0%) 700 ms (-18.09% 🔽) 2.6 s
packages/pyroscope-flamegraph/dist/index.css 7.37 KB (0%) 148 ms (0%) 0 ms (+100% 🔺) 148 ms

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 66.40% // Head: 66.63% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (c59503f) compared to base (7e82622).
Patch coverage: 77.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1545      +/-   ##
==========================================
+ Coverage   66.40%   66.63%   +0.23%     
==========================================
  Files         147      147              
  Lines        4997     4998       +1     
  Branches     1356     1155     -201     
==========================================
+ Hits         3318     3330      +12     
+ Misses       1674     1664      -10     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
...ipt/components/Heatmap/useHeatmapSelection.hook.ts 35.96% <0.00%> (+3.01%) ⬆️
webapp/javascript/components/Heatmap/index.tsx 83.75% <100.00%> (+10.92%) ⬆️
webapp/javascript/components/Heatmap/utils.ts 57.15% <100.00%> (ø)
webapp/javascript/services/exemplarsTestData.ts 100.00% <100.00%> (ø)
webapp/javascript/ui/Box.tsx 63.89% <0.00%> (ø)
webapp/javascript/ui/Button.tsx 81.82% <0.00%> (+0.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dogfrogfog dogfrogfog marked this pull request as ready for review September 26, 2022 14:49
@eh-am
Copy link
Collaborator

eh-am commented Sep 26, 2022

/create-server

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rperry2174 Rperry2174 merged commit 3218c62 into main Sep 26, 2022
@Rperry2174 Rperry2174 deleted the fix-heatmap-test branch September 26, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants