Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(annotations): allow creating multiple annotations for different apps #1562

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Sep 27, 2022

support passing an appNames array

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 443.61 KB (0%) 8.9 s (0%) 4 s (+52.4% 🔺) 12.9 s
webapp/public/assets/app.css 17.09 KB (0%) 342 ms (0%) 0 ms (+100% 🔺) 342 ms
webapp/public/assets/styles.css 9.5 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 92.18 KB (0%) 1.9 s (0%) 1.1 s (-4.36% 🔽) 3 s
packages/pyroscope-flamegraph/dist/index.node.js 92.08 KB (0%) 1.9 s (0%) 738 ms (+43.26% 🔺) 2.6 s
packages/pyroscope-flamegraph/dist/index.css 7.39 KB (0%) 148 ms (0%) 0 ms (+100% 🔺) 148 ms

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 66.63% // Head: 66.63% // No change to project coverage 👍

Coverage data is based on head (6b7ea81) compared to base (23c649d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1562   +/-   ##
=======================================
  Coverage   66.63%   66.63%           
=======================================
  Files         147      147           
  Lines        4998     4998           
  Branches     1155     1155           
=======================================
  Hits         3330     3330           
  Misses       1664     1664           
  Partials        4        4           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eh-am
Copy link
Collaborator Author

eh-am commented Sep 27, 2022

/create-server

@eh-am eh-am marked this pull request as ready for review September 27, 2022 17:44
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I am not sure having both fields is a good idea, maybe just keep one array field AppNames?

@eh-am
Copy link
Collaborator Author

eh-am commented Sep 28, 2022

@korniltsev

nit: I am not sure having both fields is a good idea, maybe just keep one array field AppNames?

Haha @petethepig and I discussed quite a lot about it, I wasn't so fond of it at the beginnig, but I guess the decision is that appName works well when you are creating a single annotation (eg via UI, which returns a single annotation), and appNames is just a utility for when creating via the API.

@eh-am eh-am merged commit 1986b11 into main Sep 28, 2022
@eh-am eh-am deleted the feat/create-multiple-annotations branch September 28, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants