-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(annotations): allow creating multiple annotations for different apps #1562
Conversation
size-limit report 📦
|
Codecov ReportBase: 66.63% // Head: 66.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
=======================================
Coverage 66.63% 66.63%
=======================================
Files 147 147
Lines 4998 4998
Branches 1155 1155
=======================================
Hits 3330 3330
Misses 1664 1664
Partials 4 4 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/create-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I am not sure having both fields is a good idea, maybe just keep one array field AppNames?
Haha @petethepig and I discussed quite a lot about it, I wasn't so fond of it at the beginnig, but I guess the decision is that |
support passing an
appNames
array