Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove gridlines in Heatmap #1567

Merged
merged 1 commit into from
Sep 28, 2022
Merged

feat: remove gridlines in Heatmap #1567

merged 1 commit into from
Sep 28, 2022

Conversation

dogfrogfog
Copy link
Contributor

Brief

Changes

  • remove gridlines in Heatmap

Screenshot 2022-09-28 at 16 26 48

Concerns

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 443.61 KB (0%) 8.9 s (0%) 3.7 s (+9.7% 🔺) 12.6 s
webapp/public/assets/app.css 17.09 KB (-0.04% 🔽) 342 ms (-0.04% 🔽) 0 ms (+100% 🔺) 342 ms
webapp/public/assets/styles.css 9.5 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 92.18 KB (0%) 1.9 s (0%) 1.2 s (+33.55% 🔺) 3.1 s
packages/pyroscope-flamegraph/dist/index.node.js 92.08 KB (0%) 1.9 s (0%) 483 ms (-44.2% 🔽) 2.4 s
packages/pyroscope-flamegraph/dist/index.css 7.39 KB (0%) 148 ms (0%) 0 ms (+100% 🔺) 148 ms

@dogfrogfog dogfrogfog marked this pull request as ready for review September 28, 2022 14:38
@Rperry2174 Rperry2174 merged commit 541133b into main Sep 28, 2022
@Rperry2174 Rperry2174 deleted the feature/remove-heatmap-grid branch September 28, 2022 16:42
@Rperry2174 Rperry2174 mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eh-am eh-am eh-am approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dogfrogfog @eh-am @Rperry2174