Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export dropdown should close when clicking outside #1579

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

dogfrogfog
Copy link
Contributor

Brief

Changes

  • close export dropdown when clicking outside or clicking export button
Screen.Recording.2022-09-30.at.11.17.30.mov

Concerns

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 66.63% // Head: 66.61% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (3bebfcc) compared to base (af71286).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
- Coverage   66.63%   66.61%   -0.01%     
==========================================
  Files         147      147              
  Lines        5004     5007       +3     
  Branches     1162     1162              
==========================================
+ Hits         3334     3335       +1     
- Misses       1665     1667       +2     
  Partials        5        5              
Impacted Files Coverage Δ
webapp/javascript/components/ExportData.tsx 37.08% <100.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 444.01 KB (+0.01% 🔺) 8.9 s (+0.01% 🔺) 4.2 s (-11.59% 🔽) 13.1 s
webapp/public/assets/app.css 17.37 KB (0%) 348 ms (0%) 0 ms (+100% 🔺) 348 ms
webapp/public/assets/styles.css 9.5 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 92.19 KB (0%) 1.9 s (0%) 1.6 s (-17.31% 🔽) 3.5 s
packages/pyroscope-flamegraph/dist/index.node.js 92.08 KB (0%) 1.9 s (0%) 707 ms (-17.16% 🔽) 2.6 s
packages/pyroscope-flamegraph/dist/index.css 7.38 KB (0%) 148 ms (0%) 0 ms (+100% 🔺) 148 ms

@dogfrogfog
Copy link
Contributor Author

/create-server

@dogfrogfog dogfrogfog marked this pull request as ready for review September 30, 2022 09:42
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Rperry2174 Rperry2174 merged commit b4074a7 into main Sep 30, 2022
@Rperry2174 Rperry2174 deleted the feature/flamegraph-export-dropdown-close branch September 30, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants