Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sorting to explore view table #1592

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

dogfrogfog
Copy link
Contributor

Brief

Changes

  • add sorting to explore view table
Screen.Recording.2022-10-04.at.14.36.04.mov

Concerns

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 444.47 KB (+0.06% 🔺) 8.9 s (+0.06% 🔺) 3.6 s (-4.92% 🔽) 12.4 s
webapp/public/assets/app.css 17.54 KB (0%) 351 ms (0%) 0 ms (+100% 🔺) 351 ms
webapp/public/assets/styles.css 9.5 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 92.19 KB (0%) 1.9 s (0%) 1.1 s (-29.22% 🔽) 2.9 s
packages/pyroscope-flamegraph/dist/index.node.js 92.08 KB (0%) 1.9 s (0%) 660 ms (-12.87% 🔽) 2.6 s
packages/pyroscope-flamegraph/dist/index.css 7.38 KB (0%) 148 ms (0%) 0 ms (+100% 🔺) 148 ms

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 66.63% // Head: 66.53% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (1c9bb64) compared to base (67227bf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1592      +/-   ##
==========================================
- Coverage   66.63%   66.53%   -0.09%     
==========================================
  Files         147      148       +1     
  Lines        5004     5031      +27     
  Branches     1161     1165       +4     
==========================================
+ Hits         3334     3347      +13     
- Misses       1665     1679      +14     
  Partials        5        5              
Impacted Files Coverage Δ
...p/javascript/components/Heatmap/HeatmapTooltip.tsx 58.47% <0.00%> (-2.25%) ⬇️
.../components/TimelineChart/TooltipWrapper/index.tsx 65.63% <0.00%> (-2.11%) ⬇️
webapp/javascript/components/Heatmap/utils.ts 57.15% <0.00%> (-0.54%) ⬇️
...ript/components/Heatmap/HeatmapTooltip.module.scss 53.85% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dogfrogfog
Copy link
Contributor Author

/create-server

@dogfrogfog dogfrogfog marked this pull request as ready for review October 4, 2022 14:34
@Rperry2174
Copy link
Contributor

/create-server

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rperry2174 Rperry2174 merged commit 64bc4b3 into main Oct 4, 2022
@Rperry2174 Rperry2174 deleted the feature/add-sort-to-tag-explorer branch October 4, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants