Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close databases in deterministic order #1623

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix: close databases in deterministic order #1623

merged 1 commit into from
Oct 18, 2022

Conversation

kolesnikovae
Copy link
Collaborator

The aim is to close databases and flush caches in deterministic order and allow using a single BadgerDB instance.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 444.86 KB (0%) 8.9 s (0%) 3.7 s (-2.47% 🔽) 12.6 s
webapp/public/assets/app.css 17.68 KB (0%) 354 ms (0%) 0 ms (+100% 🔺) 354 ms
webapp/public/assets/styles.css 9.5 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 92.19 KB (0%) 1.9 s (0%) 1.3 s (+21.7% 🔺) 3.2 s
packages/pyroscope-flamegraph/dist/index.node.js 92.08 KB (0%) 1.9 s (0%) 900 ms (+13.96% 🔺) 2.8 s
packages/pyroscope-flamegraph/dist/index.css 7.4 KB (0%) 148 ms (0%) 0 ms (+100% 🔺) 148 ms

@kolesnikovae kolesnikovae marked this pull request as ready for review October 17, 2022 17:02
@kolesnikovae kolesnikovae merged commit 7a8b33c into main Oct 18, 2022
@kolesnikovae kolesnikovae deleted the fix/storage-shutdown-order branch October 18, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petethepig petethepig petethepig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolesnikovae @petethepig