Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a generic Tooltip component #1643

Merged
merged 13 commits into from
Oct 27, 2022
Merged

feat: add a generic Tooltip component #1643

merged 13 commits into from
Oct 27, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 26, 2022

Replace our Tooltip for material ui's one:
Screen Shot 2022-10-26 at 17 54 30
Changed it to have the same look and feeling as the previous one.

Also add a TooltipInfoIcon that we can reuse anywhere.
Screen Shot 2022-10-26 at 17 47 09


Api is

    <Tooltip title="my title">
      <MyComponentThatWillTriggerTheTooltipOnHover />
    </Tooltip>

Some features:

@eh-am eh-am force-pushed the feat/add-general-tooltip branch from 89452e1 to 2914f62 Compare October 26, 2022 14:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 481.42 KB (+8.19% 🔺) 9.7 s (+8.19% 🔺) 3.2 s (+5.2% 🔺) 12.8 s
webapp/public/assets/app.css 17.93 KB (+0.27% 🔺) 359 ms (+0.27% 🔺) 0 ms (+100% 🔺) 359 ms
webapp/public/assets/styles.css 9.5 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 128.33 KB (+39.21% 🔺) 2.6 s (+39.21% 🔺) 1.7 s (+85.61% 🔺) 4.3 s
packages/pyroscope-flamegraph/dist/index.node.js 128.76 KB (+39.84% 🔺) 2.6 s (+39.84% 🔺) 636 ms (+28.24% 🔺) 3.3 s
packages/pyroscope-flamegraph/dist/index.css 7.5 KB (+1.38% 🔺) 150 ms (+1.38% 🔺) 0 ms (+100% 🔺) 150 ms

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 66.88% // Head: 66.76% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (0007891) compared to base (82bf47b).
Patch coverage: 33.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
- Coverage   66.88%   66.76%   -0.12%     
==========================================
  Files         148      147       -1     
  Lines        5018     5008      -10     
  Branches     1150     1149       -1     
==========================================
- Hits         3356     3343      -13     
- Misses       1657     1659       +2     
- Partials        5        6       +1     
Impacted Files Coverage Δ
webapp/javascript/ui/Button.module.scss 61.54% <ø> (ø)
webapp/javascript/ui/Tooltip.module.scss 53.85% <ø> (ø)
webapp/javascript/ui/Button.tsx 77.15% <14.29%> (-4.67%) ⬇️
...ages/pyroscope-flamegraph/src/SharedQueryInput.tsx 64.52% <50.00%> (-0.09%) ⬇️
webapp/javascript/ui/Tooltip.tsx 72.73% <50.00%> (-14.77%) ⬇️
webapp/javascript/components/RefreshButton.tsx

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eh-am eh-am changed the title wip feat: add a generic Tooltip component Oct 26, 2022
@eh-am eh-am marked this pull request as ready for review October 26, 2022 17:23
@eh-am
Copy link
Collaborator Author

eh-am commented Oct 27, 2022

One thing here is that I don't think the contrast against the background is good. IMO we should flip dark/light so that it has a "light" aspect.

@Rperry2174
Copy link
Contributor

One thing here is that I don't think the contrast against the background is good. IMO we should flip dark/light so that it has a "light" aspect.

what if we add a slight background shadow to it?

@Ivanikitin Ivanikitin added the frontend Mostly JS code label Oct 27, 2022
@eh-am
Copy link
Collaborator Author

eh-am commented Oct 27, 2022

/create-server

@eh-am eh-am merged commit e04a9a5 into main Oct 27, 2022
@eh-am eh-am deleted the feat/add-general-tooltip branch October 27, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Mostly JS code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants