-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a generic Tooltip component #1643
Conversation
89452e1
to
2914f62
Compare
size-limit report 📦
|
Codecov ReportBase: 66.88% // Head: 66.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1643 +/- ##
==========================================
- Coverage 66.88% 66.76% -0.12%
==========================================
Files 148 147 -1
Lines 5018 5008 -10
Branches 1150 1149 -1
==========================================
- Hits 3356 3343 -13
- Misses 1657 1659 +2
- Partials 5 6 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
One thing here is that I don't think the contrast against the background is good. IMO we should flip dark/light so that it has a "light" aspect. |
what if we add a slight background shadow to it? |
/create-server |
Replace our
Tooltip
for material ui's one:Changed it to have the same look and feeling as the previous one.
Also add a
TooltipInfoIcon
that we can reuse anywhere.Api is
Some features:
title
can take any react component, not only strings!