Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp): [notifications] support 'warning' status and arbitrary jsx element #1656

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Nov 1, 2022

Support a warning level:
Screen Shot 2022-11-01 at 09 21 24

Also support an arbitrary JSX element to be passed as message, as opposed to only strings:
Screen Shot 2022-11-01 at 09 21 35

@eh-am eh-am changed the title feat(webapp): [notifications] support 'warning' status and arbitrary … feat(webapp): [notifications] support 'warning' status and arbitrary jsx element Nov 1, 2022
@eh-am eh-am marked this pull request as ready for review November 1, 2022 09:23
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 66.10% // Head: 66.10% // No change to project coverage 👍

Coverage data is based on head (b8db3dd) compared to base (6ee40bc).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1656   +/-   ##
=======================================
  Coverage   66.10%   66.10%           
=======================================
  Files         146      146           
  Lines        4987     4987           
  Branches     1144     1144           
=======================================
  Hits         3296     3296           
  Misses       1685     1685           
  Partials        6        6           
Impacted Files Coverage Δ
webapp/javascript/ui/Notifications.tsx 39.48% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 482.34 KB (+0.01% 🔺) 9.7 s (+0.01% 🔺) 4.3 s (+18.3% 🔺) 13.9 s
webapp/public/assets/app.css 18 KB (0%) 360 ms (0%) 0 ms (+100% 🔺) 360 ms
webapp/public/assets/styles.css 9.52 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 128.33 KB (0%) 2.6 s (0%) 1.7 s (-6.86% 🔽) 4.3 s
packages/pyroscope-flamegraph/dist/index.node.js 128.76 KB (0%) 2.6 s (0%) 724 ms (-25.62% 🔽) 3.3 s
packages/pyroscope-flamegraph/dist/index.css 7.5 KB (0%) 150 ms (0%) 0 ms (+100% 🔺) 150 ms

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eh-am eh-am merged commit 2ec2b07 into main Nov 2, 2022
@eh-am eh-am deleted the feat/allow-arbitrary-jsx-in-notifications branch November 2, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants