-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webapp): pass from,until when calling /label{-values} #1677
Conversation
size-limit report 📦
|
Codecov ReportBase: 66.68% // Head: 66.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1677 +/- ##
==========================================
- Coverage 66.68% 66.25% -0.43%
==========================================
Files 156 157 +1
Lines 5285 5344 +59
Branches 1208 1219 +11
==========================================
+ Hits 3524 3540 +16
- Misses 1755 1798 +43
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…-timerange-to-labels
/create-server |
The backend expects
from
anduntil
query parameters in the/labels
and/label-values
endpoints.Here we pass them.
The catch is that to not have to have different set of tags for different time ranges, we just take the biggest time range between left/right/regular. This implies that we may pass a bigger time range than necessary, but it's fine.
Also this has another downside: every time the range changes, we also have to load labels again, which is redundant most of the times. In the future we may do some optimization like storing the {from, until} interval and only load when a different range outside the cached range is passed.Also Store the
{from, until}
interval which an app loaded labels refers to. That way we don't have to reload again if loading from a subrange.A small refactor, but removed
TagsBar
fromToolbar
in SingleView to keep it consistent with the other views.