feat: show percentages for diff table instead of absolute values #1697
Conversation
size-limit report 📦
|
Codecov ReportBase: 66.22% // Head: 66.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
==========================================
- Coverage 66.22% 66.00% -0.22%
==========================================
Files 164 168 +4
Lines 5441 5519 +78
Branches 1220 1241 +21
==========================================
+ Hits 3603 3642 +39
- Misses 1831 1868 +37
- Partials 7 9 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/create-server |
dogfrogfog
changed the title
|
/create-server |
Screen.Recording.2022-11-11.at.16.16.40.mov |
|
/create-server |
|
I think this looks great... I think we should just make the table have the exact same 3 columns as the tooltip has :
Let's remove the 3 button options for now
wdyt @petethepig ? |
|
@Rperry2174 yeah that makes sense |
|
/create-server |
|
|
|
Looks great.. lets also show the same data that shows on the flamegraph over the table as well for the tooltip: vs
|
|
/create-server |
Screen.Recording.2022-11-15.at.13.39.05.mov |
|
/create-server |
There was a problem hiding this comment.
Just to be sure, are we getting rid of these?
cc @Rperry2174
|
yes, i removed code for this buttons |
yes I think we should get rid of them (tbh many don't know what they actually mean anyway) |
|
/create-server |
|
/create-server |
Brief
Changes
demo link: https://pr-1697.pyroscope.io/comparison-diff?query=rideshare-app-golang.alloc_objects%7B%7D&rightQuery=rideshare-app-golang.alloc_objects%7B%7D&leftQuery=rideshare-app-golang.alloc_objects%7B%7D
Screen.Recording.2022-11-10.at.13.52.08.mov
Concerns
i think we can either show smth like < 0.01 % like we do with absolute values or increase number of digits after comma