Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable "reset view" button when table item is highlighted #1703

Merged

Conversation

dogfrogfog
Copy link
Contributor

@dogfrogfog dogfrogfog commented Nov 11, 2022

Brief

Changes

Screen.Recording.2022-11-11.at.12.26.49.mov

Concerns

  • nope

@dogfrogfog
Copy link
Contributor Author

/create-server

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 490.02 KB (+0.01% 🔺) 9.9 s (+0.01% 🔺) 5 s (+1.68% 🔺) 14.8 s
webapp/public/assets/app.css 19.28 KB (0%) 386 ms (0%) 0 ms (+100% 🔺) 386 ms
webapp/public/assets/styles.css 9.52 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 131.67 KB (+0.02% 🔺) 2.7 s (+0.02% 🔺) 2.6 s (+21.79% 🔺) 5.3 s
packages/pyroscope-flamegraph/dist/index.node.js 132.35 KB (+0.01% 🔺) 2.7 s (+0.01% 🔺) 866 ms (-10.95% 🔽) 3.6 s
packages/pyroscope-flamegraph/dist/index.css 8.28 KB (0%) 166 ms (0%) 0 ms (+100% 🔺) 166 ms

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 66.22% // Head: 66.21% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (b603215) compared to base (8d92b0a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1703      +/-   ##
==========================================
- Coverage   66.22%   66.21%   -0.01%     
==========================================
  Files         164      164              
  Lines        5441     5442       +1     
  Branches     1220     1220              
==========================================
  Hits         3603     3603              
- Misses       1831     1832       +1     
  Partials        7        7              
Impacted Files Coverage Δ
...e-flamegraph/src/FlameGraph/FlameGraphRenderer.tsx 49.41% <100.00%> (-0.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dogfrogfog dogfrogfog marked this pull request as ready for review November 11, 2022 12:06
@Ivanikitin Ivanikitin added the frontend Mostly JS code label Nov 11, 2022
@Rperry2174 Rperry2174 merged commit 7b1bfd5 into main Nov 11, 2022
@Rperry2174 Rperry2174 deleted the feature/add-reset-item-when-table-item-is-highlighted branch November 11, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Mostly JS code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants