Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(panel-plugin): remove leaky css #1709

Merged
merged 4 commits into from
Nov 14, 2022
Merged

fix(panel-plugin): remove leaky css #1709

merged 4 commits into from
Nov 14, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Nov 14, 2022

fixes pyroscope-io/grafana-panel-plugin#7

We don't need that CSS anymore since we now ship all required css nested under a pyroscope css element.

Before:
Screen Shot 2022-11-14 at 10 11 22

After:
Screen Shot 2022-11-14 at 10 10 38

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 490.47 KB (0%) 9.9 s (0%) 3.6 s (-21.71% 🔽) 13.4 s
webapp/public/assets/app.css 19.3 KB (0%) 386 ms (0%) 0 ms (+100% 🔺) 386 ms
webapp/public/assets/styles.css 9.52 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 131.84 KB (0%) 2.7 s (0%) 1.6 s (-37.9% 🔽) 4.2 s
packages/pyroscope-flamegraph/dist/index.node.js 132.47 KB (0%) 2.7 s (0%) 595 ms (-20.8% 🔽) 3.3 s
packages/pyroscope-flamegraph/dist/index.css 8.3 KB (0%) 167 ms (0%) 0 ms (+100% 🔺) 167 ms

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 66.24% // Head: 66.26% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (61e316a) compared to base (00a204f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
+ Coverage   66.24%   66.26%   +0.02%     
==========================================
  Files         165      165              
  Lines        5455     5464       +9     
  Branches     1221     1224       +3     
==========================================
+ Hits         3613     3620       +7     
- Misses       1835     1837       +2     
  Partials        7        7              
Impacted Files Coverage Δ
...graph/src/FlameGraph/FlameGraphComponent/index.tsx 81.64% <0.00%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eh-am eh-am marked this pull request as ready for review November 14, 2022 11:21
@eh-am eh-am merged commit bc28930 into main Nov 14, 2022
@eh-am eh-am deleted the fix/panel-plugin-css branch November 14, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding pyroscope panel corrupts light mode CSS
1 participant