-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webapp): add tooltip to main timeline in single view #1742
Conversation
size-limit report 📦
|
Codecov ReportBase: 66.38% // Head: 66.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1742 +/- ##
==========================================
- Coverage 66.38% 66.25% -0.12%
==========================================
Files 168 169 +1
Lines 5522 5561 +39
Branches 1243 1260 +17
==========================================
+ Hits 3665 3684 +19
- Misses 1848 1867 +19
- Partials 9 10 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/create-server |
webapp/javascript/components/TimelineChart/ExploreTooltip/index.tsx
Outdated
Show resolved
Hide resolved
@eh-am can you please test this logic on short timeline period before merging |
/create-server |
Overall
Closes #1739
Adds a tooltip when hovering over the timeline in SingleView
Implementation
Create a
TimelineTooltip
component which just takes the following props:And renders as is.
Point here is to move the calculations to the caller, since each page may have different values/formats (eg tag explorer).
Also refactors
<ExploreTooltip>
to use this newTimelineTooltip
.Ah, fixes #1740 too
Some other comments
As it's clear, the Tooltip plugin (from float) has an annoying api, forcing us to access items such as
It's a good idea to refactor that plugin.