Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): Tag Explorer loading spinner consistent with other pages #1748

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

pavelpashkovsky
Copy link
Contributor

@pavelpashkovsky pavelpashkovsky commented Nov 21, 2022

Brief

Changes

Monosnap.screencast.2022-11-21.12-39-10.mp4

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 66.25% // Head: 66.24% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (f5752dd) compared to base (6fcc988).
Patch coverage: 66.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
- Coverage   66.25%   66.24%   -0.01%     
==========================================
  Files         169      169              
  Lines        5561     5562       +1     
  Branches     1260     1261       +1     
==========================================
  Hits         3684     3684              
- Misses       1867     1868       +1     
  Partials       10       10              
Impacted Files Coverage Δ
.../javascript/redux/reducers/continuous/selectors.ts 56.15% <66.67%> (-1.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 492.49 KB (+0.01% 🔺) 9.9 s (+0.01% 🔺) 4.6 s (+15.47% 🔺) 14.4 s
webapp/public/assets/app.css 19.99 KB (0%) 400 ms (0%) 0 ms (+100% 🔺) 400 ms
webapp/public/assets/styles.css 9.56 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 131.27 KB (0%) 2.7 s (0%) 2.1 s (+0.02% 🔺) 4.8 s
packages/pyroscope-flamegraph/dist/index.node.js 131.96 KB (0%) 2.7 s (0%) 777 ms (+2.91% 🔺) 3.5 s
packages/pyroscope-flamegraph/dist/index.css 8.29 KB (0%) 166 ms (0%) 0 ms (+100% 🔺) 166 ms

@pavelpashkovsky
Copy link
Contributor Author

/create-server

@eh-am eh-am merged commit c1c83c2 into main Nov 21, 2022
@eh-am eh-am deleted the tags-explorer-loading branch November 21, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants