Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make table rows only take one line #1765

Merged
merged 4 commits into from
Nov 28, 2022
Merged

fix: make table rows only take one line #1765

merged 4 commits into from
Nov 28, 2022

Conversation

dogfrogfog
Copy link
Contributor

@dogfrogfog dogfrogfog commented Nov 28, 2022

Brief

Changes

  • increase width of profile table columns
Screen.Recording.2022-11-28.at.11.01.32.mov

@dogfrogfog
Copy link
Contributor Author

/create-server

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 493.17 KB (+0.01% 🔺) 9.9 s (+0.01% 🔺) 3.2 s (-14.73% 🔽) 13 s
webapp/public/assets/app.css 19.68 KB (+0.24% 🔺) 394 ms (+0.24% 🔺) 0 ms (+100% 🔺) 394 ms
webapp/public/assets/styles.css 9.6 KB (+0.4% 🔺) 192 ms (+0.4% 🔺) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 129.84 KB (+0.02% 🔺) 2.6 s (+0.02% 🔺) 1.4 s (-28.92% 🔽) 4 s
packages/pyroscope-flamegraph/dist/index.node.js 130.57 KB (+0.01% 🔺) 2.7 s (+0.01% 🔺) 605 ms (+11.21% 🔺) 3.3 s
packages/pyroscope-flamegraph/dist/index.css 7.97 KB (+0.55% 🔺) 160 ms (+0.55% 🔺) 0 ms (+100% 🔺) 160 ms

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 65.84% // Head: 66.28% // Increases project coverage by +0.44% 🎉

Coverage data is based on head (3e441da) compared to base (c36aa9c).
Patch coverage: 33.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
+ Coverage   65.84%   66.28%   +0.44%     
==========================================
  Files         170      170              
  Lines        5561     5562       +1     
  Branches     1258     1258              
==========================================
+ Hits         3661     3686      +25     
+ Misses       1890     1866      -24     
  Partials       10       10              
Impacted Files Coverage Δ
...ackages/pyroscope-flamegraph/src/ProfilerTable.tsx 56.63% <33.34%> (+0.27%) ⬆️
...lameGraph/FlameGraphComponent/Flamegraph_render.ts 91.47% <0.00%> (+14.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dogfrogfog
Copy link
Contributor Author

/create-server

@dogfrogfog
Copy link
Contributor Author

/create-server

@dogfrogfog dogfrogfog marked this pull request as ready for review November 28, 2022 10:25
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@Rperry2174 Rperry2174 merged commit 6d33d42 into main Nov 28, 2022
@Rperry2174 Rperry2174 deleted the fix/table-2-lines branch November 28, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants