Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select function sandwich view message is in wrong location #1767

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

dogfrogfog
Copy link
Contributor

Brief

Changes

  • fix sandwich message location

Screenshot 2022-11-28 at 17 35 41

@dogfrogfog
Copy link
Contributor Author

/create-server

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 493.21 KB (+0.01% 🔺) 9.9 s (+0.01% 🔺) 3.8 s (+18.09% 🔺) 13.6 s
webapp/public/assets/app.css 19.7 KB (+0.1% 🔺) 394 ms (+0.1% 🔺) 0 ms (+100% 🔺) 394 ms
webapp/public/assets/styles.css 9.6 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 129.85 KB (0%) 2.6 s (0%) 1.3 s (-33.14% 🔽) 3.9 s
packages/pyroscope-flamegraph/dist/index.node.js 130.58 KB (0%) 2.7 s (0%) 715 ms (+13.51% 🔺) 3.4 s
packages/pyroscope-flamegraph/dist/index.css 7.97 KB (0%) 160 ms (0%) 0 ms (+100% 🔺) 160 ms

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 66.44% // Head: 66.44% // No change to project coverage 👍

Coverage data is based on head (8abf8b9) compared to base (6d33d42).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1767   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files         170      170           
  Lines        5551     5551           
  Branches     1257     1257           
=======================================
  Hits         3688     3688           
  Misses       1853     1853           
  Partials       10       10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dogfrogfog dogfrogfog marked this pull request as ready for review November 28, 2022 16:50
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Rperry2174 Rperry2174 merged commit 6720c3f into main Nov 28, 2022
@Rperry2174 Rperry2174 deleted the fix-sandwich-message-location branch November 28, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants